Add GKE-specific conditions to toolkit #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds conditions from GKE into `toolkit/k8s/verify.go` to fix toolkit's `verify k8s-ready` commnad failing on GKE. Signed-off-by: Ryan Drew <[email protected]>
|
Hey @christarazi do you mind checking this out if you have a second and seeing if there are any other conditions off the top of your head that should be added? |
christarazi
reviewed
Oct 14, 2022
christarazi
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds conditions from GKE into
toolkit/k8s/verify.goto fix toolkit'sverify k8s-readycommnad failing on GKE.Signed-off-by: Ryan Drew [email protected]